[WebDriver BiDi] addPreloadScript supports contexts
#41932
Merged
+173
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf-2
approved these changes
Sep 12, 2023
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
thiagowfx
requested changes
Sep 13, 2023
webdriver/tests/bidi/script/add_preload_script/add_preload_script.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/script/add_preload_script/add_preload_script.py
Outdated
Show resolved
Hide resolved
Lightning00Blade
force-pushed
the
bidi-preload-script-add-contexts
branch
from
1d65c07
to
3e09b79
Compare
thiagowfx
approved these changes
Sep 14, 2023
whimboo
requested changes
Sep 15, 2023
4 tasks
|
Hi @Lightning00Blade, will you have a chance to continue on this PR? |
Lightning00Blade
force-pushed
the
bidi-preload-script-add-contexts
branch
from
3e09b79
to
b6a1af2
Compare
Lightning00Blade
force-pushed
the
bidi-preload-script-add-contexts
branch
from
b6a1af2
to
3207e30
Compare
thiagowfx
approved these changes
Oct 10, 2023
whimboo
requested changes
Oct 11, 2023
webdriver/tests/bidi/script/add_preload_script/add_preload_script.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/script/add_preload_script/add_preload_script.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/script/add_preload_script/add_preload_script.py
Outdated
Show resolved
Hide resolved
whimboo
requested changes
Oct 18, 2023
webdriver/tests/bidi/script/add_preload_script/add_preload_script.py
Outdated
Show resolved
Hide resolved
Lightning00Blade
force-pushed
the
bidi-preload-script-add-contexts
branch
from
226f4bf
to
18163fe
Compare
webdriver/tests/bidi/script/add_preload_script/contexts_tentative.py
Outdated
Show resolved
Hide resolved
Lightning00Blade
force-pushed
the
bidi-preload-script-add-contexts
branch
from
18163fe
to
2b16dcf
Compare
sadym-chromium
approved these changes
Dec 14, 2023
whimboo
requested changes
Dec 14, 2023
webdriver/tests/bidi/script/add_preload_script/contexts_tentative.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/script/add_preload_script/contexts_tentative.py
Outdated
Show resolved
Hide resolved
webdriver/tests/bidi/script/add_preload_script/contexts_tentative.py
Outdated
Show resolved
Hide resolved
whimboo
requested changes
Dec 20, 2023
webdriver/tests/bidi/script/add_preload_script/add_preload_script.py
Outdated
Show resolved
Hide resolved
whimboo
approved these changes
Jan 5, 2024
|
@Lightning00Blade I think that this PR needs an admin merge. |
|
CC @web-platform-tests/admins for admin merge request. As per the last comment, errors seem unrelated to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to BiDi spec at w3c/webdriver-bidi#517.
Closes #41974